feat(webhook): add imdbid to webhook notification#2658
feat(webhook): add imdbid to webhook notification#2658
Conversation
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
📝 WalkthroughWalkthroughAdded support for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@server/lib/notifications/agents/webhook.ts`:
- Line 28: The template variable media_imdbid is populated only from
payload.media.imdbId, but Media.imdbId is optional and often empty at request
creation; update the notification-building path to ensure the IMDb ID is
resolved before dispatch: either populate payload.media.imdbId from available
request-time metadata (e.g., payload.metadata or request.mediaInfo) or
lookup/fallback to a reliable field (e.g., external_ids or metadata.imdb) when
constructing the webhook context, so media_imdbid is set; adjust the code that
assembles the webhook payload/template context (the place referencing
payload.media.imdbId) to perform this fallback/resolution synchronously prior to
sending.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dac9fd27-53a8-41a2-b65d-c5967e1a76b9
📒 Files selected for processing (3)
docs/using-seerr/notifications/webhook.mdserver/lib/notifications/agents/webhook.tssrc/components/Settings/Notifications/NotificationsWebhook/index.tsx
Description
How Has This Been Tested?
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit