Added a q3c_sindist_bool function to allow for calculating a better Selectivity#35
Open
gshennessy wants to merge 1 commit into
Open
Added a q3c_sindist_bool function to allow for calculating a better Selectivity#35gshennessy wants to merge 1 commit into
gshennessy wants to merge 1 commit into
Conversation
Owner
|
I looked at the patch, but I actually forgot that I already have selectivity on for the q3c_join() so nothing is needed there. It is done through the weird operator Line 209 in 040de14 with this selectivity function In fact explain select * from gaia_dr3.gaia_source as g, gaia_dr3.gaia_source as g1 where q3c_join(g.ra,g.dec,g1.ra,g1.dec,5./3600);estimates the number of rows to be 60 millions which is pretty sensible (given it asssumes independent positions). So I don't think q3c_join can be improved with your patch. What I can do is to do the same thing for q3c_radial_query() which currently doesnt' have the selectivity implemented |
Author
|
I need to do more A/B testing, if only for my own understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have a selectivity function for q3c_sindist_bool.