Gtm bugfix2 #840
Open
Gtm bugfix2 #840
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the GTM domain configurable for the GTM Classic web destination.
Are there breaking changes in this PR?
NO.
Testing
Destination instance
https://app.segment.build/joe-ayoub-segment-stage/destinations/google-tag-manager/sources/gtm_test_3/instances/6989db2527c15b15e1c5d48a/configuration
Version pinned here.
https://github.com/segmentio/analytics.js-versions/commit/78a95bde128ad548071456cbbda675ec1d47145f
With custom URL configured.
Default behaviour, without custom URL configured.
Note this fixes an issue which caused a SEV 3. inc-sev3-17182-gtm-events-not-flowing-after-domain-change-2026-02-06
Existing Unit Tests
Since the existing unit tests for several integrations are not in good shape, developers are expected to fix
them for the integration they are working/touch on.
Please ensure the following before submitting a PR:
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources