Flush after writing image.#27
Open
NathanSweet wants to merge 1 commit into
Open
Conversation
Other ImageIO writers do this, eg JPEGImageWriter. Without the flush, when using something like a javax.imageio.stream.MemoryCacheImageOutputStream, the cached data is never written to the underlying stream like it is with all other JRE writers.
joostoudeman
pushed a commit
to joostoudeman/webp-imageio
that referenced
this pull request
Jun 16, 2023
|
This is it! I need answer that why webp file has 0kb file size. It should be merged. |
yuripourre
approved these changes
May 27, 2024
|
Why haven't this pull request been merged? Could someone please do it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other ImageIO writers do this, eg JPEGImageWriter. Without the flush, when using something like a javax.imageio.stream.MemoryCacheImageOutputStream, the cached data is never written to the underlying stream like it is with all other JRE writers.