Skip to content

Fix special characters in OAuth secret #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriaanzon merged 1 commit into from
Apr 14, 2026
Merged

Fix special characters in OAuth secret #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/Modules/OAuth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,18 @@ public function initialize_credentials(): void
{
if (get_option('sendy_client_id') == '') {
update_option('sendy_client_id', wp_generate_uuid4());
update_option('sendy_client_secret', wp_generate_password(40), false);
update_option('sendy_client_secret', wp_generate_password(40, false), false);
update_option('sendy_hostname', get_site_url());

return;
}

// Regenerate secrets that contain characters requiring URL-encoding.
// Such characters (e.g. #, %) break the OAuth URL even when percent-encoded,
// because WordPress's esc_url() can revert %23 to # which browsers treat as a fragment separator.
$secret = get_option('sendy_client_secret');
if ($secret !== false && $secret !== '' && ! sendy_is_authenticated() && rawurlencode($secret) !== $secret) {
update_option('sendy_client_secret', wp_generate_password(40, false), false);
}
}

Expand All @@ -47,7 +57,7 @@ public function reset_credentials_when_access_token_nullified($old_value, $value

if (get_option('sendy_hostname') != get_site_url()) {
update_option('sendy_client_id', wp_generate_uuid4());
update_option('sendy_client_secret', wp_generate_password(40), false);
update_option('sendy_client_secret', wp_generate_password(40, false), false);
update_option('sendy_hostname', get_site_url());

update_option('sendy_refresh_token', null, false);
Expand Down
Loading