Skip to content

Fix build#3

Open
lucasoshiro wants to merge 4 commits intosequincozes:masterfrom
lucasoshiro:fix
Open

Fix build#3
lucasoshiro wants to merge 4 commits intosequincozes:masterfrom
lucasoshiro:fix

Conversation

@lucasoshiro
Copy link
Copy Markdown

Hi!

I was trying to set up and run ERENO, but I couldn't by only using the current master branch and its README. This PR introduces small changes that I did in order to run:

  • f8fa5a1: remove an extra }, as the code won't compile with it
  • 361e733: generated by IntelliJ when bumping JDK to version 21
  • 1643331: add some IntelliJ files to .gitignore, basically copied from https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
  • 858d0c4: add a note about Tomcat version. ERENO won't run with Tomcat 10 in the latest master. I bisected the code and found that it is due to the changes introduced in 0e3a5df (the previous commit is ok). I tried to fix it by myself but I couldn't as I don't have experience with Tomcat.

@lucasoshiro lucasoshiro changed the title Fix Fix build Mar 10, 2024
@sequincozes
Copy link
Copy Markdown
Owner

sequincozes commented May 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants