Skip to content

added argument: embedvideo can be set to false to make logs less heavy #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hassineabd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added argument: embedvideo can be set to false to make logs less heavy #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions AppiumLibrary/keywords/_screenrecord.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ def stop_screen_recording(self, filename=None, **options):

=== Optional Args ===

- ``embedVideo`` Set it to false to skip embedding the recorded video into log.html.
Applies to Android when no remotePath is provided. Defaults to true.

- ``remotePath`` The path to the remote location, where the resulting video should be \
uploaded. The following protocols are supported _http/https_, ftp. Null or empty \
string value (the default setting) means the content of resulting file should \
Expand All @@ -93,19 +96,20 @@ def stop_screen_recording(self, filename=None, **options):
| `Stop Screen Recording` | filename=output | # saves the recorded session |
"""
if self._recording is not None:
embed_video = options.pop('embedVideo', True)
self._recording = self._current_application().stop_recording_screen(**options)
return self._save_recording(filename, options)
return self._save_recording(filename, options, embed_video)
else:
raise RuntimeError("There is no Active Screen Record Session.")

def _save_recording(self, filename, options):
def _save_recording(self, filename, options, embed_video=True):
path, link = self._get_screenrecord_paths(options, filename)
decoded = base64.b64decode(self._recording)
with open(path, 'wb') as screenrecording:
screenrecording.write(decoded)
# Embed the Screen Recording to the log file
# if the current platform is Android and no remotePath is set.
if self._is_android() and not self._is_remotepath_set(options):
if embed_video and self._is_android() and not self._is_remotepath_set(options):
self._html('</td></tr><tr><td colspan="3"><a href="{vid}">'
'<video width="800px" controls>'
'<source src="{vid}" type="video/mp4">'
Expand Down