Add ATTACH_ON_FAILURE environment variable feature#6
Merged
Conversation
Implements automatic HTTP request/response recording when ATTACH_ON_FAILURE=true. When enabled, the pytest hook automatically attaches exchanges to Allure on test failure. Changes: - Modified client.py to check ATTACH_ON_FAILURE env var - Records exchanges silently without immediate attachment - Pytest hook attaches on failure for automatic debugging Tests Added: - test_attach_on_failure.py: Unit test with mock transport - test_pytest_hook_attach_on_failure.py: Hook integration test - test_attach_on_failure_integration.py: Real Spotify API validation - test_attach_on_failure_demo.py: Demo test (skipped by default) Other: - Fixed Makefile serve-report target to use poetry run All tests passing: 24/24 (1 skipped demo test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements automatic HTTP request/response recording when ATTACH_ON_FAILURE=true. When enabled, the pytest hook automatically attaches exchanges to Allure on test failure.
Changes:
Tests Added:
Other:
All tests passing: 24/24 (1 skipped demo test)