Skip to content
This repository was archived by the owner on Jun 21, 2026. It is now read-only.

Always build universal binaries on macOS#1229

Open
paulfd wants to merge 1 commit into
developfrom
paulfd/build-universal-always
Open

Always build universal binaries on macOS#1229
paulfd wants to merge 1 commit into
developfrom
paulfd/build-universal-always

Conversation

@paulfd

@paulfd paulfd commented Jan 15, 2024

Copy link
Copy Markdown
Member

No description provided.

@redtide

redtide commented Jan 15, 2024

Copy link
Copy Markdown
Member

I think this is not necessary here, I thought we could make st_audiofile a standalone repo with its own CI workflow and do this there instead.

@paulfd

paulfd commented Jan 15, 2024

Copy link
Copy Markdown
Member Author

Doing both is also an option!

@redtide

redtide commented Jan 15, 2024

Copy link
Copy Markdown
Member

I still have the same idea about not to "abuse" of CI resources (after the Travis experience...). Other than that, builds are quite a lot and takes forever if there is some activity on the repo.
So if you care to set the universal build here, then forget my previous comment.

@redtide

redtide commented Jan 15, 2024

Copy link
Copy Markdown
Member

Anyway.. this is strange, disabling WAVPACK_ENABLE_ASM was working before, unless it's something different this time. Is it possible that it needs to cache the var in CMake?

@redtide

redtide commented Jan 15, 2024

Copy link
Copy Markdown
Member

Erm... my bad, I forgot about this, and also confused for some reason that the issue was on the plugins side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants