Feature: run templater code if button type is not set#300
Open
eugritz wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for buttons-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When user creates a button using Button Maker and chooses button type "Template", user has to choose the template note and an action. The default option for action is "Do this...". I presume it's supposed to mean an unselected value that does nothing, and it acts exactly this way.
However, in case of more complex operations, such as updating different parts of note, template notes can operate with current note without returning a value, so it should be possible to execute a template note without returning a value. As of now, this is not possible, and any attempts to do this interfere with buttons plugin.
The recently introduced feature
replacedoesn't help either, because it replaces contents of the file before executing the template, so it's impossible to get previous contents of the file.This PR changes the behavior of buttons: if action is not set, it executes the template without interfering with any changes introduced to current note.