Fix crash when running codeman with no args under bash nounset#3
Open
shabo wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes macOS default Bash (3.2) compatibility issues and improves Discord/Slack notifications so they work in real interactive usage.
What changed
set -ucrash when runningcodemanwith no args (empty-array expansion).mapfileusage (not available in Bash 3.2) with portablewhile readloops.batsregression tests plus CI matrix (Ubuntu + macOS) and expanded ShellCheck coverage.CODEMAN_NOTIFY_ON=...,message).CODEX_HOME(defaults to~/.codex).v0.1.3.Why
set -uas an error (unbound variable).mapfile, socodeman l3 ...could fail.task_complete/ approval waits; interactive usage needs message-level pings.ASCII flow
+-------------------+
| start (set -euo) |
+-------------------+
|
v
+-------------------+
| parse args/flags |
+-------------------+
|
v
+-------------------------------+
| run codex + tail session log |
| (from $CODEX_HOME/sessions) |
+-------------------------------+
|
v
+-----------------------------------------------+
| on new session lines: |
| - wait: denial markers -> Discord/Slack ping |
| - message: agent_message -> Discord/Slack ping |
| - complete: task_complete -> Discord/Slack ping|
+-----------------------------------------------+