Fix empty hlsfactory.toml for DGNN_Booster_convLSTM + add config audit script#87
Open
CharithKumarGunda wants to merge 1 commit into
Open
Fix empty hlsfactory.toml for DGNN_Booster_convLSTM + add config audit script#87CharithKumarGunda wants to merge 1 commit into
CharithKumarGunda wants to merge 1 commit into
Conversation
…_Booster_convLSTM
Author
|
Update: I mainaged to also migrated the full PolyBench dataset to hlsfactory.toml config files (all 9 designs: atax, bicg, gemm, gesummv, k2mm, k3mm, mvt, syr2k, syrk). Each design uses the same flow pattern (VitisHLSSynthFlow, VitisHLSCosimSetupFlow, VitisHLSImplFlow) based on their existing dataset_hls.tcl files. I made sure to also validated all 9 with read_design_config() - and found no errors. Ran audit_configs.py again to confirm: polybench now shows 9/9 designs with valid configs. This PR now includes both the DGNN_Booster_convLSTM fix and the full PolyBench migration. Happy to continue with MachSuite and CHStone next if this approach looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while exploring issue #69 (New Design Configuration), I wrote the script (audit_configs.py) to check which designs have a valid hlsfactory.toml file and validate them using read_design_config.
This audit found that hlsfactory/hls_dataset_sources/accelerators/DGNN_Booster_convLSTM/hlsfactory.toml was an empty (0-byte) file, causing a DesignConfigError:
design_nameis required.I fixed this by acutally creating a proper hlsfactory.toml based on the existing dataset_hls.tcl entry point and the format used by other designs (e.g. soda__blur).
The audit script also shows which datasets still need hlsfactory.toml files created (polybench, machsuite, chstone, forgebench, and others) - happy to help with this migration if useful!