Add hlsfactory.toml design configs for remaining datasetsAdd design configs batch#88
Open
CharithKumarGunda wants to merge 3 commits into
Open
Conversation
…_Booster_convLSTM
Runs the official hlsfactory.scripts.generate_design_configs migration script across all dataset sources that were missing design config files. This auto-detects existing TCL flow scripts (dataset_hls.tcl, dataset_hls_ip_export.tcl, opt_template.tcl, etc.) per design and emits a matching hlsfactory.toml, with no HLS tool invocation required. Newly covered datasets (174 designs total): - machsuite (18/18) - accelerators (7/7) - chstone (2/2) - flowgnn (5/5) - forgebench (45/45) - hp_fft_hls (16/16) - pp4fpgas (5/5) - class_ece8893_spring_2025 (77/86 - 9 remaining have non-standard layouts) Also: - Removes generate_polybench_tomls.py, a hardcoded one-off script whose functionality is fully covered by the official generator. - Moves audit_configs.py into hlsfactory/scripts/audit_design_configs.py as a proper importable module (uv run python -m hlsfactory.scripts.audit_design_configs), made path-independent, and given a real exit code so it can be used in CI. - Verified: 0 validation errors against the DesignConfig schema across all newly generated and pre-existing config files. Remaining gaps (tracked separately, need non-mechanical work): - auto_ntt: not a flat design dir, generates 17 sub-kernel projects via setup.sh; needs a template-aware config approach. - class_ece8893_2022_fall / 2023_spring: designs nested under source_code/ subdirectories, not detected by current TCL patterns. - gnnbuilder, hlsyn, hlsyn-vitis, polybench__reproducible, rosetta: no recognized TCL filenames present at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation work from issue #69 to migrate all designs to the new hlsfactory.toml config format.
Includes:
All configs validated with audit_configs.py - no errors.
Closes #69