Skip to content

fix: defer late foreign key links#192

Merged
Jozsef Damokos (jozsefdamokos) merged 4 commits into
trunkfrom
fix/fk-conversions
May 27, 2026
Merged

fix: defer late foreign key links#192
Jozsef Damokos (jozsefdamokos) merged 4 commits into
trunkfrom
fix/fk-conversions

Conversation

@jozsefdamokos

@jozsefdamokos Jozsef Damokos (jozsefdamokos) commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • strip late self/forward FK fields during initial migration writes
  • migrate product canonicalProductId and cmsPageId in follow-up datasets
  • migrate sales channel homeCmsPageId in a follow-up dataset after CMS pages
  • keep hreflangDefaultDomainId on its existing delayed domain-based path and harden the first pass
  • strip promotionId defensively to avoid FK failures when promotions are not migrated
  • add converter fixtures/tests and admin snippet labels for the new simulated datasets

fixes: shopware/shopware#10610 shopware/shopware#10609 shopware/shopware#10611

larskemper
Lars Kemper (larskemper) approved these changes May 26, 2026
View reviewed changes
Comment thread tests/_fixtures/Shopware6/Promotion/02-StripPromotionAssociation/input.php Outdated
vintagesucks
Nikolas Evers (vintagesucks) approved these changes May 26, 2026
View reviewed changes
Comment thread src/DependencyInjection/shopware6.php Outdated
@jozsefdamokos Jozsef Damokos (jozsefdamokos) merged commit 8a12eec into trunk May 27, 2026
10 checks passed
@jozsefdamokos Jozsef Damokos (jozsefdamokos) deleted the fix/fk-conversions branch May 27, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DennisGarding Dennis Garding (DennisGarding) DennisGarding approved these changes

@vintagesucks Nikolas Evers (vintagesucks) vintagesucks approved these changes

@larskemper Lars Kemper (larskemper) larskemper approved these changes

@MalteJanz Malte Janz (MalteJanz) Awaiting requested review from MalteJanz MalteJanz was automatically assigned from shopware/product-cc-after-sales

@CR0YD Simon Fiebranz (CR0YD) Awaiting requested review from CR0YD CR0YD was automatically assigned from shopware/product-cc-after-sales

Assignees

@jozsefdamokos Jozsef Damokos (jozsefdamokos)

Labels

qi/candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SW6->SW6: Product cmsPageId prevents migration of products if set

5 participants

@jozsefdamokos @DennisGarding @vintagesucks @larskemper @MalteJanz