fix: consider time zone during migration of orders#9
Merged
Conversation
Dennis Garding (DennisGarding)
requested review from
Simon Fiebranz (CR0YD),
Malte Janz (MalteJanz),
Susanne Hartung (ennasus4sun),
Jozsef Damokos (jozsefdamokos),
Lars Kemper (larskemper) and
Nikolas Evers (vintagesucks)
and removed request for
a team
Jozsef Damokos (jozsefdamokos)
requested changes
Apr 27, 2026
Malte Janz (MalteJanz)
requested changes
Apr 28, 2026
Dennis Garding (DennisGarding)
requested review from
Malte Janz (MalteJanz),
Jozsef Damokos (jozsefdamokos) and
Lars Kemper (larskemper)
Contributor
|
That linked PR was closed without any comment, can you add a comment to it and point to the correct Assistant PR here? I guess it should be this one shopware/SwagMigrationAssistant#186 ? Also are these draft PRs "ready for review" or do you just want a quick review on the broader architecture / solution and a proper review later? Would be nice if you could write a comment if you request review on draft PRs what your expectations are or put it out of draft mode for a full review. |
Jozsef Damokos (jozsefdamokos)
approved these changes
May 7, 2026
Lars Kemper (larskemper)
approved these changes
May 8, 2026
Nikolas Evers (vintagesucks)
approved these changes
May 11, 2026
Malte Janz (MalteJanz)
requested changes
May 12, 2026
Malte Janz (MalteJanz)
left a comment
Malte Janz (MalteJanz)
left a comment
Contributor
There was a problem hiding this comment.
As already said in the other PR, this solution likely is not feasible unless you find a clean way to support it in the Assistant:
shopware/SwagMigrationAssistant#186 (review)
Malte Janz (MalteJanz)
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is necessary to complete the issue: shopware/shopware#14186
See PR: shopware/SwagMigrationAssistant#186