You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 9, 2020. It is now read-only.
The list of devices is now dynamic. The BLE scan has a duration of BLE_SCAN_DURATION. It looks for devices with root UUID matching 0xfe95 (flora device identifier).
Then the initial processing is applied on each device.
Now it just tries to process all the flora devices around... is it not better to scan and then process only the one in the list? I did that for my local version.
In my case, it is easier to have a full dynamic list. I don't have neighbor using Flora, and I could filter out in MQTT if need be. I prefer to have the config in the MQTT (that I can access remotely), than on the ESP (which I need to connect to).
Then, even if multiple ESP scan the same devices, this will "only" add another value, I don't see it as a potential conflict.
But this is not an issue as well to add a filter that is either a list of address to keep or empty (no filtering). It could match both use cases :).
hi,
its possible to merge it into dev-branch? Or at least to update your PullRequest along current dev-branch?
Maybe, an enhancement: to disable a MAC-Adress via WebForm from scanning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of devices is now dynamic. The BLE scan has a duration of BLE_SCAN_DURATION. It looks for devices with root UUID matching 0xfe95 (flora device identifier).
Then the initial processing is applied on each device.
This should address issue #19