Merged
Conversation
Add regression test that demonstrates the field ordering bug where cast_table_safe fails when source table fields are in a different order than the target schema, even when all field names and types match.
Reorder source table columns to match target schema order before casting. PyArrow's cast() matches fields by position, not name, so tables with different field ordering would fail even when all field names and types matched.
Member
|
Much appreciated @hentzthename |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Nico, I think I found a bug while using this package.
Problem
When loading JSON data (where field order isn't guaranteed), subsequent loads could fail with:
This occurs because PyArrow's
table.cast()matches fields by position, not by name. Fails even though all field names and types match.Solution
Reorder source table columns to match target schema order before casting
Changes
tests/test_schema_casting.py: Add test for field orderingsrc/dlt_iceberg/schema_casting.py: Add column reordering beforetable.cast()incast_table_safe()