Skip to content

fix(element-theme): reduce button padding to align with design specs#1803

Open
ljanner wants to merge 1 commit intomainfrom
fix/reduce-button-padding
Open

fix(element-theme): reduce button padding to align with design specs#1803
ljanner wants to merge 1 commit intomainfrom
fix/reduce-button-padding

Conversation

@ljanner
Copy link
Copy Markdown
Member

@ljanner ljanner commented Apr 2, 2026

@ljanner ljanner added this to the 49.x milestone Apr 2, 2026
@ljanner ljanner self-assigned this Apr 2, 2026
@ljanner ljanner added the enhancement Topics that make the project better label Apr 2, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates button styling by reducing horizontal padding and refactoring icon margins, which resulted in updated visual snapshots. A review comment suggests that the current use of margin-inline-end on icons may lead to asymmetrical spacing when an icon is the trailing element; it recommends using the gap property on the button container or applying conditional margins to ensure consistent spacing regardless of the icon's position.

@ljanner ljanner force-pushed the fix/reduce-button-padding branch 2 times, most recently from 88822f8 to 7850111 Compare April 2, 2026 16:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

⬇️ Download VRTs

@ljanner ljanner force-pushed the fix/reduce-button-padding branch from 7850111 to 01b13e0 Compare April 2, 2026 16:42
@ljanner
Copy link
Copy Markdown
Member Author

ljanner commented Apr 2, 2026

I've opted to do the snapshot updates in the same commit as the change itself, because from my understanding this is the preferred way. Additionally I used element-theme as a scope as this is where the change takes place, but I can also see the argument to use buttons as a scope instead.

@ljanner ljanner marked this pull request as ready for review April 2, 2026 17:01
@ljanner ljanner requested review from a team as code owners April 2, 2026 17:01
Copy link
Copy Markdown
Member

@panch1739 panch1739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljanner A masterpiece, a delight to the sight, the most magical PR i have seen in my life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Topics that make the project better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change button padding to 8px

2 participants