fix(element-theme): reduce button padding to align with design specs#1803
fix(element-theme): reduce button padding to align with design specs#1803
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates button styling by reducing horizontal padding and refactoring icon margins, which resulted in updated visual snapshots. A review comment suggests that the current use of margin-inline-end on icons may lead to asymmetrical spacing when an icon is the trailing element; it recommends using the gap property on the button container or applying conditional margins to ensure consistent spacing regardless of the icon's position.
88822f8 to
7850111
Compare
7850111 to
01b13e0
Compare
|
I've opted to do the snapshot updates in the same commit as the change itself, because from my understanding this is the preferred way. Additionally I used element-theme as a scope as this is where the change takes place, but I can also see the argument to use buttons as a scope instead. |
Resolves #1801
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: