fixup(loading-buttons): align ghost button loading spinner color with design specs#1817
Open
fixup(loading-buttons): align ghost button loading spinner color with design specs#1817
Conversation
… design specs Related to #1793
ljanner
force-pushed
the
fixup/ghost-button-loading
branch
from
54c6fd9 to
da18645
Compare
ljanner
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the si-loading-button component to support additional ghost button variants by expanding the CSS selectors and updating the loading spinner color to use the primary text variable. It also adds a new ghost button example to the documentation and updates the corresponding visual regression snapshots. One review comment was provided regarding a style guide violation: the commit message scope should be corrected to match the component's folder name, loading-spinner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was missing in #1793
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: