Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements scrolling functionality for tree-structured data in the datatable component, including a utility to expand parent rows and corresponding unit tests. The review feedback points out a logic flaw in the scrollToRow method where the function continues execution after calling the tree-specific scroll handler, which leads to redundant operations and potential double-scrolling. Additionally, a performance concern was raised regarding the expandToRow utility, which rebuilds a lookup map on every call; the reviewer suggests optimizing this by pre-calculating the map to handle large datasets more efficiently.
Actually a feature, but since we did not release scrolling at all it is labeled as refactor. This adds scrolling for the tree mode. It basically works as scrolling in the normal mode. The only difference is that in tree mode we may need to expand rows before scrolling.
spike-rabbit
force-pushed
the
refactor/datatable/scrolling-with-tree
branch
from
51d3eee to
2cfdc91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Scrolling to item does not support tree mode.
What is the new behavior?
Scrolling to item supports tree mode.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Actually a feature, but since we did not release scrolling at all it is labeled as refactor.
It basically works as scrolling in the normal mode. The only difference is that in tree mode we may need to expand rows before scrolling.