Logic channel color sequencing#119
Open
jgartrel wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I humbly beseech the maintainers that be, that they might accept this pull request. I know this might seem pedantic, however, most manufacturers of ribbon cable in the last 20 years start with brown, red ... with black next to white at the other side of the cable (for 10 wire, or 40 wire ribbon cable).
This pull request adds an option to the view settings to change the color offset for the logical channels. This allows a user to set the first color used for channels to be brown (or some other color) by default (instead of black)
Setting a value of "1" for the "Logic color offset" assigns brown as the color for channel 0, red as channel 1, etc... This has the following benefits:
The default for the color offset is: "0", allowing for the traditional look of pulseview to remain unchanged and work well with the Saleae logic analyzers that use black for channel 0.
I did my best with the translations for German, Spanish, Japanese, and Chinese. Those will certainly need a review.