Implement Edit Listing page with update, pause, delete, and cancel operations

[Copilot]

Implements the Edit Listing page for Sharers to modify active and draft listings. The page supports full CRUD operations with state transitions per business rules.

Backend Changes

Application Services

• Extended update.ts to accept all listing fields (title, description, category, location, sharingPeriod, images) instead of just admin flags
• Added pause.ts service for pausing listings (moves to Paused state)
• Updated return type from void to ItemListingEntityReference for cache consistency

GraphQL Schema

• Added UpdateItemListingInput with optional fields for partial updates
• Added mutations: updateItemListing, pauseItemListing, deleteItemListing
• All mutations return ItemListing for Apollo cache updates

Resolvers

• Implemented null-safe field updates in updateItemListing
• deleteItemListing uses soft delete pattern (sets isDeleted: true)
• All mutations enforce authentication and ownership verification before operations
• Added explicit ownership checks to ensure only the listing owner (sharer) can update, pause, delete, or cancel their listings

Resolver Helpers

• Fixed PopulateUserFromField to return the full user object with userType augmented, preserving all user fields for clients

Frontend Changes

Components

• edit-listing.container.tsx: GraphQL integration with 5 mutations (update, pause, delete, cancel), pre-populates form from query
• edit-listing.tsx: Two-column layout (image gallery left, form right), confirmation modals for destructive actions
• edit-listing-form.tsx: Conditionally renders Pause (Published only) and Cancel Listing (Published/Drafted/Paused) buttons based on listing state

Route Integration

• Wired to /my-listings/user/:userId/:listingId/edit
• Reuses ImageGallery from create-listing component

Usage

// Container fetches listing and provides CRUD operations
<EditListingContainer isAuthenticated={auth.isAuthenticated} />

// Form conditionally shows actions based on state
{canPause && <Button onClick={onPause}>Pause</Button>}
{canCancel && <Button onClick={onCancel}>Cancel Listing</Button>}

State transitions follow domain rules: Published → Paused, Published/Drafted/Paused → Cancelled, any → Deleted.

Other Fixes

• Updated .gitignore to properly exclude **/node_modules and **/dist patterns

• Removed accidentally committed build artifacts from packages/sthrift/service-twilio

• Fixes Listing - Edit Listing #221

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Listing - Edit Listing</issue_title>
<issue_description>## Context
This issue proposes the implementation of the Edit Listing page for Sharers, as depicted in the attached screenshot. This view enables users to edit details of an active or draft listing, consistent with design and requirements from the SRD/BRD documents.

References:

• Business Requirements Document (BRD) — Sections: Listing Processing > Edit Listing
• System Requirements Document (SRD) — User Journeys: Listing > Edit Listing

Requirements

• Page must allow editing of the following listing fields:
  • Title
  • Location
  • Category (dropdown)
  • Reservation Period (date range picker)
  • Description (character count enforced)
  • Listing photos (image upload, preview, delete)
• Listing actions:
  • Save Changes
  • Cancel
  • Delete (permanently removes listing)
  • Cancel Listing (moves to cancelled state, see SRD)
  • Pause (moves to paused state, see SRD)
• Page layout must match the provided screenshot, including sidebar navigation, listing preview, and form controls.
• All required fields must be validated and error states shown according to UI guidelines.
• Permission logic must ensure only the listing owner may edit/delete/pause/cancel the listing (see BRD/SRD for rules).
• Integrate with backend API for update, delete, pause, and cancel actions.
• Show success/error messages for actions using Ant Design components.
• Accessible (ARIA, keyboard navigation, semantic HTML).
• Responsive design and proper alignment.

Additional Information

• Use Ant Design components and Tailwind CSS for styling as described in UI Instructions.
• Implement error and loading states using <Skeleton />, <Empty />, and Ant Design <message /> for feedback.
• All actions must respect business logic for listing states (active, draft, cancelled, paused, deleted) as defined in the SRD/BRD.

---

Acceptance Criteria

• User can edit all editable listing fields and save changes
• User can upload/remove listing photos
• Actions (Delete, Cancel Listing, Pause) correctly update listing state and are only enabled per business rules
• UI matches provided screenshot and adheres to accessibility and style guidelines
• All changes are persisted via backend API and error/success feedback is shown

---

For additional requirements and business rules, see:

• BRD: Listing Processing > Edit Listing
• SRD: Listing > Edit Listing
  </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Listing - Edit Listing #221

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Summary by Sourcery

Add full Edit Listing functionality for item listings, including frontend page, GraphQL mutations, backend application services, and supporting infrastructure updates.

New Features:

• Introduce an Edit Listing page and container that allow owners to update listing details, manage images, and perform pause, cancel, and delete actions based on listing state.
• Expose GraphQL mutations and input types for updating, pausing, cancelling, and deleting item listings, returning updated listing data for client cache consistency.
• Add a Twilio service package wrapper to support conversations and messaging via a typed service interface.

Bug Fixes:

• Fix date handling for listing reservation periods by normalizing to UTC midnight and ensuring robust parsing of date-only strings.
• Correct ListingState semantics by treating both Published and Active states as active and updating tests accordingly.
• Improve user-field resolution in GraphQL resolvers to handle various parent shapes safely and always return a normalized user object with userType metadata.
• Ensure the mock payment server can start reliably by probing for a free port when the default port is already in use.

Enhancements:

• Extend the item listing update application service and tests to support updating all core fields, images, and request deletion, and to return the updated entity reference.
• Add a dedicated pause application service with BDD tests to encapsulate pausing listings within a transaction-aware unit of work.
• Refine create/edit listing layout and button styling for better responsiveness, spacing, and mobile behavior, and adjust home layout content width handling with a responsive sidebar margin.
• Add Storybook stories and documentation for the Edit Listing UI to support manual QA and design review.
• Tighten resolver helpers and value-object tests to better reflect allowed state values and requested field path handling.

Build:

• Allow disabling Storybook in Vitest runs for the UI app to speed up coverage runs and avoid Storybook-specific configuration during test execution.
• Introduce pnpm-level dependency overrides (e.g., node-forge) and workspace overrides to keep transitive dependencies up to date and secure.

Documentation:

• Add detailed test case and completion summary documentation for the Edit Listing feature, covering scenarios, user journeys, and how to run the tests.

Tests:

• Add comprehensive Vitest/BDD coverage for listing update, pause logic, listing value objects, GraphQL resolver helpers, and the Edit Listing UI and containers, including table navigation to the edit page.
• Update SonarQube coverage exclusions to account for the new Edit Listing UI directory and generated or support files.

[jason-t-hankins]

@sourcery-ai review

[sourcery-ai]

Sorry @jason-t-hankins, your pull request is larger than the review limit of 150000 diff characters

[Copilot]

Pull request overview

This PR implements a comprehensive Edit Listing feature for Sharers to modify their listings with full CRUD operations. The implementation spans backend GraphQL mutations, application services, domain logic, and a complete frontend UI with proper authentication and ownership verification.

Key Changes:

• Added GraphQL mutations for update, pause, delete, and cancel operations on listings
• Extended backend services to support partial field updates and new pause functionality
• Implemented ownership verification to ensure only listing owners can perform actions
• Created responsive Edit Listing UI with conditional action buttons based on listing state
• Fixed resolver helpers to properly populate user data with userType information

Reviewed changes

Copilot reviewed 53 out of 56 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/sthrift/graphql/src/schema/types/listing/item-listing.graphql	Added UpdateItemListingInput and new mutations (update, pause)
packages/sthrift/graphql/src/schema/types/listing/item-listing.resolvers.ts	Implemented mutations with authentication and ownership checks
packages/sthrift/application-services/src/contexts/listing/item/update.ts	Extended to accept all listing fields and return entity reference
packages/sthrift/application-services/src/contexts/listing/item/pause.ts	New service for pausing listings with UoW transaction
packages/sthrift/graphql/src/schema/resolver-helper.ts	Fixed PopulateUserFromField to always return full user object with userType
apps/ui-sharethrift/src/components/layouts/home/components/edit-listing/	Complete Edit Listing UI with container, form, and stories
apps/ui-sharethrift/src/components/layouts/home/my-listings/Index.tsx	Added route for Edit Listing page
pnpm-lock.yaml, package.json	Updated Storybook to 9.1.17, added node-forge override
.gitignore	Fixed to properly exclude **/node_modules and **/dist

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

[jasonmorais]

not fully done but wanted to leave you some feedback to work on tomorrow so you have something to do

[jasonmorais]

We have this weird route that both link to the same component

[jason-t-hankins]

I think Vaibhav added this before I joined on the edit listing effort. I think the intention may be for admins to be able to view user's listings and be able to eventually edit them in the same way. We could either leave it for now or just remove the two excess paths from each

[Copilot]

Pull request overview

Copilot reviewed 50 out of 53 changed files in this pull request and generated no new comments.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported