migrate vitest to v4

apps/docs/package.json

@@ -36,10 +36,10 @@
 		"@testing-library/react": "^16.1.0",
 		"@types/react": "^19.1.11",
 		"@types/react-dom": "^19.1.6",
-		"@vitest/coverage-v8": "^3.2.4",
+		"@vitest/coverage-v8": "catalog:",
 		"jsdom": "^26.1.0",
-		"typescript": "~5.6.2",
-		"vitest": "^3.2.4"
+		"typescript": "^5.8.3",
+		"vitest": "catalog:"
 	},
 	"browserslist": {
 		"production": [

apps/ui-sharethrift/package.json

@@ -12,7 +12,7 @@
 		"storybook": "storybook dev -p 6006",
 		"build-storybook": "storybook build",
 		"test": "vitest run",
-		"test:coverage": "vitest run --coverage",
+		"test:coverage:ui": "vitest run --coverage",
 		"test:watch": "vitest"
 	},
 	"dependencies": {
@@ -47,17 +47,16 @@
 		"@types/react": "^19.1.9",
 		"@types/react-dom": "^19.1.7",
 		"@vitejs/plugin-react": "^4.7.0",
-		"@vitest/browser": "3.2.4",
-		"@vitest/coverage-v8": "^3.2.4",
+		"@vitest/coverage-v8": "catalog:",
 		"eslint": "^9.30.1",
 		"eslint-plugin-react-hooks": "^5.2.0",
 		"eslint-plugin-react-refresh": "^0.4.20",
 		"globals": "^16.3.0",
 		"storybook": "catalog:",
 		"typescript": "~5.8.3",
 		"typescript-eslint": "^8.35.1",
-		"vite": "^7.1.2",
-		"vitest": "^3.2.4"
+		"vite": "catalog:",
+		"vitest": "catalog:"
 	},
 	"license": "MIT"
 }

apps/ui-sharethrift/src/App.container.stories.tsx

@@ -45,7 +45,7 @@ const mockAuthenticatedNotCompletedOnboarding = {
 	},
 	result: {
 		data: {
-			currentUser: {
+			currentUserAndCreateIfNotExists: {
 				__typename: 'PersonalUser' as const,
 				id: 'user-456',
 				userType: 'personal-user',

apps/ui-sharethrift/src/components/layouts/home/account/profile/stories/ProfilePage.stories.tsx

@@ -7,6 +7,7 @@ import {
 import {
 	HomeAccountProfileViewContainerCurrentUserDocument,
 	HomeAccountProfileViewContainerUserListingsDocument,
+	UseUserIsAdminDocument,
 	type ItemListing,
 	type PersonalUser,
 } from '../../../../../../generated.tsx';
@@ -86,6 +87,19 @@ const mockTwoListings: ItemListing[] = [
 	},
 ];
 
+const userIsAdminMockRequest = (userId: string) => {
+	return {
+		request: {
+			query: UseUserIsAdminDocument,
+		},
+		result: {
+			data: {
+				currentUser: {id: userId, userIsAdmin: false },
+			},
+		},
+	};
+};
+
 const meta: Meta<typeof HomeRoutes> = {
 	title: 'Pages/Account/Profile',
 	component: HomeRoutes,
@@ -113,21 +127,28 @@ export const DefaultView: Story = {
 					},
 					result: {
 						data: {
-							currentPersonalUserAndCreateIfNotExists: mockUserSarah,
+							currentUser: mockUserSarah,
 						},
 					},
 				},
 
 				{
 					request: {
 						query: HomeAccountProfileViewContainerUserListingsDocument,
+						variables: { page: 1, pageSize: 100 },
 					},
 					result: {
 						data: {
-							itemListings: mockTwoListings,
+							myListingsAll: {
+								items: mockTwoListings,
+								total: 2,
+								page: 1,
+								pageSize: 100,
+							},
 						},
 					},
 				},
+				userIsAdminMockRequest(mockUserSarah.id),
 			],
 		},
 	},
@@ -143,20 +164,22 @@ export const NoListings: Story = {
 					},
 					result: {
 						data: {
-							currentPersonalUserAndCreateIfNotExists: mockUserAlex,
+							currentUser: mockUserAlex,
 						},
 					},
 				},
 				{
 					request: {
 						query: HomeAccountProfileViewContainerUserListingsDocument,
+						variables: { page: 1, pageSize: 100 },
 					},
 					result: {
 						data: {
-							itemListings: [],
+							myListingsAll:  { items: [], total: 0, page: 1, pageSize: 100 },
 						},
 					},
 				},
+				userIsAdminMockRequest(mockUserAlex.id),
 			],
 		},
 	},

build-pipeline/core/monorepo-build-stage.yml

@@ -224,6 +224,7 @@ stages:
         targetType: 'inline'
         script: |
           set -euo pipefail
+          echo "Open file limit (ulimit -n): $(ulimit -n)"
           export NODE_OPTIONS=--max_old_space_size=16384
           export PLAYWRIGHT_BROWSERS_PATH="$(PLAYWRIGHT_BROWSERS_PATH)"
 
@@ -238,10 +239,15 @@ stages:
           pnpm audit --audit-level=high --prod
 
           # Use Turbo's built-in --affected flag for accurate change detection
+          # Split coverage collection: Node tests first, then Storybook tests separately
+          # to reduce race conditions and memory pressure in CI
           if [ "$(Build.Reason)" = "PullRequest" ] || [ "$(Build.SourceBranch)" != "refs/heads/main" ]; then
             echo "Testing affected packages only (PR/branch build)..."
             export TURBO_SCM_BASE="origin/$(System.PullRequest.TargetBranch)"
-            pnpm run test:coverage --affected
+            echo "Running Node unit tests with coverage..."
+            pnpm run test:coverage:node --affected
+            echo "Running Storybook/Playwright tests with coverage..."
+            pnpm run test:coverage:ui --affected
             pnpm run merge-lcov-reports
           else
             echo "Testing all packages (main branch build)..."

package.json

@@ -27,7 +27,9 @@
         "start-emulator:payment-server": "pnpm run start --workspace=@cellix/mock-payment-server",
         "start-emulator:messaging-server": "pnpm run start --workspace=@sthrift/mock-messaging-server",
         "test:all": "turbo run test:all",
-        "test:coverage": "turbo run test:coverage",
+        "test:coverage": "turbo run test:coverage:ui && turbo run test:coverage:node",
+        "test:coverage:node": "turbo run test:coverage:node",
+        "test:coverage:ui": "turbo run test:coverage:ui",
         "test:coverage:merge": "pnpm run test:coverage && pnpm run merge-lcov-reports",
         "merge-lcov-reports": "node build-pipeline/scripts/merge-coverage.js",
         "test:integration": "turbo run test:integration",
@@ -56,7 +58,7 @@
         }
     },
     "devDependencies": {
-        "@amiceli/vitest-cucumber": "^5.1.2",
+        "@amiceli/vitest-cucumber": "^6.1.0",
         "@biomejs/biome": "2.0.0",
         "@graphql-codegen/cli": "^5.0.7",
         "@graphql-codegen/introspection": "^4.0.3",
@@ -68,7 +70,8 @@
         "@playwright/test": "^1.55.1",
         "@sonar/scan": "^4.3.0",
         "@types/node": "^24.7.2",
-        "@vitest/coverage-v8": "^3.2.4",
+        "@vitest/browser-playwright": "catalog:",
+        "@vitest/coverage-v8": "catalog:",
         "azurite": "^3.35.0",
         "concurrently": "^9.1.2",
         "cpx2": "^3.0.2",
@@ -79,7 +82,7 @@
         "tsx": "^4.20.3",
         "turbo": "^2.5.8",
         "typescript": "^5.8.3",
-        "vite": "^7.0.4",
-        "vitest": "^3.2.4"
+        "vite": "catalog:",
+        "vitest": "catalog:"
     }
 }

packages/cellix/domain-seedwork/package.json

@@ -17,7 +17,7 @@
 		"build": "tsc --build",
 		"watch": "tsc --watch",
 		"test": "vitest run",
-		"test:coverage": "vitest run --coverage",
+		"test:coverage:node": "vitest run --coverage",
 		"test:watch": "vitest",
 		"lint": "biome lint",
 		"clean": "rimraf dist"

packages/cellix/domain-seedwork/src/domain-seedwork/handle-event.test.ts

@@ -15,7 +15,7 @@ const feature = await loadFeature(
 class TestEvent extends DomainEventBase {}
 
 test.for(feature, ({ Scenario }) => {
-  let handlerFn: ReturnType<typeof vi.fn>;
+  let handlerFn: (event: TestEvent) => void;
   let handler: HandleEventImpl<TestEvent>;
   let event: TestEvent;
 
@@ -40,7 +40,7 @@ test.for(feature, ({ Scenario }) => {
       event = new TestEvent('agg-2');
     });
     When('I register the function using the static register method', () => {
-      handler = HandleEventImpl.register<TestEvent>(handlerFn) as HandleEventImpl<TestEvent>;
+      handler = HandleEventImpl.register<TestEvent>(handlerFn as (event: TestEvent) => void) as HandleEventImpl<TestEvent>;
     });
     Then('I should get a handler that calls the function when handling an event', () => {
       handler.handle(event);
@@ -59,8 +59,8 @@ test.for(feature, ({ Scenario }) => {
     Given('multiple handlers for a domain event', () => {
       handlerFn1 = vi.fn();
       handlerFn2 = vi.fn();
-      handler1 = new HandleEventImpl<TestEvent>(handlerFn1);
-      handler2 = new HandleEventImpl<TestEvent>(handlerFn2);
+      handler1 = new HandleEventImpl<TestEvent>(handlerFn1 as (event: TestEvent) => void);
+      handler2 = new HandleEventImpl<TestEvent>(handlerFn2 as (event: TestEvent) => void);
       event = new TestEvent('agg-3');
     });
     When('I register them all using registerAll', () => {

packages/cellix/event-bus-seedwork-node/package.json

@@ -17,7 +17,7 @@
 		"build": "tsc --build",
 		"watch": "tsc --watch",
 		"test": "vitest run",
-		"test:coverage": "vitest run --coverage",
+		"test:coverage:node": "vitest run --coverage",
 		"test:watch": "vitest",
 		"lint": "biome lint",
 		"clean": "rimraf dist"

packages/cellix/event-bus-seedwork-node/src/in-proc-event-bus.test.ts

@@ -18,11 +18,11 @@ class TestEventA extends DomainSeedwork.CustomDomainEventImpl<{ testA: string }>
 class TestEventB extends DomainSeedwork.CustomDomainEventImpl<{ testB: string }> {}
 
 test.for(feature, ({ Scenario, BeforeEachScenario }) => {
-  let handler: ReturnType<typeof vi.fn>;
-  let handler1: ReturnType<typeof vi.fn>;
-  let handler2: ReturnType<typeof vi.fn>;
-  let handlerA: ReturnType<typeof vi.fn>;
-  let handlerB: ReturnType<typeof vi.fn>;
+  let handler: (payload: { test: string }) => Promise<void>;
+  let handler1: (payload: { test: string }) => Promise<void>;
+  let handler2: (payload: { test: string }) => Promise<void>;
+  let handlerA: (payload: { testA: string }) => Promise<void>;
+  let handlerB: (payload: { testB: string }) => Promise<void>;
   let error: unknown;
 
   // Reset the singleton's subscribers for isolation before each scenario

packages/cellix/event-bus-seedwork-node/src/node-event-bus.test.ts

@@ -50,11 +50,11 @@ class EventA extends DomainSeedwork.CustomDomainEventImpl<{ a: string }> {}
 class EventB extends DomainSeedwork.CustomDomainEventImpl<{ b: string }> {}
 
 test.for(feature, ({ Scenario, Background, BeforeEachScenario }) => {
-  let handler: ReturnType<typeof vi.fn>;
-  let handler1: ReturnType<typeof vi.fn>;
-  let handler2: ReturnType<typeof vi.fn>;
-  let handlerA: ReturnType<typeof vi.fn>;
-  let handlerB: ReturnType<typeof vi.fn>;
+  let handler: (payload: { test: string }) => Promise<void>;
+  let handler1: (payload: { test: string }) => Promise<void>;
+  let handler2: (payload: { test: string }) => Promise<void>;
+  let handlerA: (payload: { a: string }) => Promise<void>;
+  let handlerB: (payload: { b: string }) => Promise<void>;
 
   BeforeEachScenario(() => {
     handler = vi.fn().mockResolvedValue(undefined);
@@ -135,8 +135,8 @@ test.for(feature, ({ Scenario, Background, BeforeEachScenario }) => {
       // handlerA, handlerB, EventA, EventB are already defined
     });
     When('each handler is registered for a different event', () => {
-      NodeEventBusInstance.register(EventA, handlerA);
-      NodeEventBusInstance.register(EventB, handlerB);
+      NodeEventBusInstance.register(EventA, handlerA as (payload: { a: string }) => Promise<void>);
+      NodeEventBusInstance.register(EventB, handlerB as (payload: { b: string }) => Promise<void>);
     });
     And('each event is dispatched', async () => {
       await NodeEventBusInstance.dispatch(EventA, { a: 'A' });
@@ -287,8 +287,14 @@ test.for(feature, ({ Scenario, Background, BeforeEachScenario }) => {
     let callOrder: string[];
     Given('multiple handlers for the same event class', () => {
       callOrder = [];
-      handler1 = vi.fn(() => callOrder.push('handler1'));
-      handler2 = vi.fn(() => callOrder.push('handler2'));
+      handler1 = vi.fn(() => {
+        callOrder.push('handler1');
+        return Promise.resolve();
+      });
+      handler2 = vi.fn(() => {
+        callOrder.push('handler2');
+        return Promise.resolve();
+      });
     });
     When('all handlers are registered', () => {
       NodeEventBusInstance.register(TestEvent, handler1);
@@ -341,7 +347,7 @@ test.for(feature, ({ Scenario, Background, BeforeEachScenario }) => {
   Scenario('Dispatch does not wait for handler completion', ({ Given, When, And, Then }) => {
     let handlerStarted = false;
     let handlerCompleted = false;
-    let asyncHandler: ReturnType<typeof vi.fn>;
+    let asyncHandler: (payload: { test: string }) => Promise<void>;
     Given('a handler for an event that is asynchronous', () => {
       asyncHandler = vi.fn(async () => {
         handlerStarted = true;

packages/cellix/mongoose-seedwork/package.json

@@ -17,7 +17,7 @@
 		"build": "tsc --build",
 		"watch": "tsc --watch",
 		"test": "vitest run",
-		"test:coverage": "vitest run --coverage",
+		"test:coverage:node": "vitest run --coverage",
 		"test:integration": "vitest run integration.test.ts",
 		"test:unit": "vitest run --exclude tests/integration/**/*.test.ts",
 		"test:watch": "vitest",