Skip to content

Fix CI#385

Open
simonrw wants to merge 1 commit intomainfrom
ci/fix
Open

Fix CI#385
simonrw wants to merge 1 commit intomainfrom
ci/fix

Conversation

@simonrw
Copy link
Copy Markdown
Owner

@simonrw simonrw commented Feb 21, 2026

Summary by CodeRabbit

  • Chores
    • Updated CI workflows to standardise Linux dependency installation by adding a preparation step before installing system packages. This improves reliability and consistency of build environments across stable, nightly and test pipelines.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 21, 2026

Walkthrough

Multiple GitHub Actions workflow steps were modified to replace a single-line apt-get install with a multi-line sequence that runs apt-get update followed by installing libwebkit2gtk-4.1-dev on Linux runners.

Changes

Cohort / File(s) Summary
GitHub Actions workflows — check jobs
.github/workflows/check.yml
Replaced single-line apt-get install with a multi-line block that runs sudo apt-get update then installs libwebkit2gtk-4.1-dev in the "Install system dependencies" step for clippy, doc and hack jobs.
GitHub Actions workflows — scheduled jobs
.github/workflows/scheduled.yml
Replaced single-line apt-get install with a block that runs sudo apt-get update then installs libwebkit2gtk-4.1-dev in both nightly and update jobs.
GitHub Actions workflows — test jobs
.github/workflows/test.yml
Replaced single-line apt-get install with a multi-line block that runs sudo apt-get update then installs libwebkit2gtk-4.1-dev in required and minimal jobs' "Install system dependencies" steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰
I hopped through CI at break of dawn,
Updated apt so builds roll on,
Installed WebKit, tidy and spry,
Runners hum beneath the sky,
A rabbit's nod — the checks run on.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix CI' is vague and does not clearly specify what CI issue is being addressed or what the actual changes entail. Provide a more descriptive title that specifies the CI fix, such as 'Add apt-get update to system dependency installation steps in CI workflows' to better convey the changeset scope.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In @.github/workflows/scheduled.yml:
- Around line 70-74: The "Install Linux system deps" step is duplicated (same
commands and condition), so refactor to avoid repetition: extract the block with
the step name "Install Linux system deps" and its run commands (sudo apt-get
update... and sudo apt-get install -y --no-install-recommends
libwebkit2gtk-4.1-dev) into a reusable unit (either a YAML anchor/alias, a
composite action, or a reusable workflow) and replace the duplicated instances
with references to that unit while preserving the if: runner.os == 'Linux'
guard.

In @.github/workflows/test.yml:
- Around line 70-74: No change required—keep the "Install Linux system deps"
step as-is: ensure the step named "Install Linux system deps" uses the same
conditional (if: runner.os == 'Linux') and the two commands (sudo apt-get update
-o Acquire::Retries=3 and sudo apt-get install -y --no-install-recommends
libwebkit2gtk-4.1-dev) so it matches the correct pattern used by the required
job.

Fixes 404 errors in CI when the runner's package index is stale.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/test.yml (1)

24-26: LGTM – correct two-step apt-get update + install fix.

Prefixing with apt-get update ensures the package index is fresh before installation, which is the standard resolution for package-not-found failures on GitHub-hosted runners.

As an optional nicety, adding --no-install-recommends keeps the runner leaner and can shave a few seconds off the step:

✨ Optional: reduce install surface
-          sudo apt-get install -y libwebkit2gtk-4.1-dev
+          sudo apt-get install -y --no-install-recommends libwebkit2gtk-4.1-dev
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/test.yml around lines 24 - 26, Two-step apt usage
currently runs "sudo apt-get update" then "sudo apt-get install -y
libwebkit2gtk-4.1-dev"; keep the explicit update but change the install
invocation to use the --no-install-recommends flag to reduce installed surface
and speed the step (i.e., modify the install line to include
--no-install-recommends for libwebkit2gtk-4.1-dev).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/test.yml:
- Around line 24-26: Two-step apt usage currently runs "sudo apt-get update"
then "sudo apt-get install -y libwebkit2gtk-4.1-dev"; keep the explicit update
but change the install invocation to use the --no-install-recommends flag to
reduce installed surface and speed the step (i.e., modify the install line to
include --no-install-recommends for libwebkit2gtk-4.1-dev).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant