Conversation
damonge
requested changes
Mar 6, 2026
Collaborator
There was a problem hiding this comment.
looks good. Ideally we wouldn't have to copy over the whole code from compsep to compsep_nopipe to avoid maintaining both at the same time. However, I understand this is only a preliminary step to migrating out of BBpipe entirely (perhaps in a separate repo).
Two things:
- Check the one comment I made.
- How about renaming the new config and run.sh files from
sat_wmap...tonopipe, so it's easier for us to find these examples in the future?
Comment on lines
+2
to
+7
| import sys | ||
| import os | ||
| sys.path.append( | ||
| os.path.abspath(os.path.join(os.path.dirname(__file__), '.')) | ||
| ) | ||
|
|
Collaborator
There was a problem hiding this comment.
OK, I think I know why you need it, but do you know if this interferes with the non-nopipe running of bbpower?
Collaborator
Author
There was a problem hiding this comment.
I need it since if I import bbpower as a package instead, I will need to have bbpipe installed. I checked that this works with the old tests and the new example.
Collaborator
Author
|
Renamed example, tested old and new examples, linting and small fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding convenience scripts to limit dependence on less-maintainted code pieces. The original functionalities remain unchanged. The main changes are:
A real-life example runscript has been added (requires access to the tiger computing cluster).