Skip to content

Remove imp.load_dynamic from load_pybindings#207

Merged
mhasself merged 1 commit intomasterfrom
remove-imp
Feb 25, 2025
Merged

Remove imp.load_dynamic from load_pybindings#207
mhasself merged 1 commit intomasterfrom
remove-imp

Conversation

@mhasself
Copy link
Member

This hasn't been used for a while -- spt3g has offered dload since Feb 2024.

Resolves #181

This hasn't been used for a while -- spt3g has offered dload since Feb
2024.
@mhasself mhasself requested a review from tskisner February 25, 2025 15:15
@mhasself
Copy link
Member Author

@tskisner I suspect this will be made obsolete by the new spt3g integration ... but just trying to close out some issues in the meantime.

@tskisner
Copy link
Member

Yeah, the file is deleted in #204, but I can rebase that after this is merged.

Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to remove stale code! :-)

@mhasself mhasself merged commit 4106442 into master Feb 25, 2025
2 checks passed
@mhasself mhasself deleted the remove-imp branch February 25, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importlib warnings need to be addressed

2 participants