Fix preproc hwp freq logging#1588
Merged
mmccrackan merged 3 commits intomasterfrom Mar 24, 2026
Merged
Conversation
msilvafe
approved these changes
Mar 24, 2026
Contributor
msilvafe
left a comment
msilvafe
left a comment
There was a problem hiding this comment.
One inline comment but approved.
| if fmax >= frequency_cutoff: | ||
| logger.warning(f"Upper freq={fmax} > hwp_freq={hwp_freq}. Limiting to hwp_freq.") | ||
| if fmax > frequency_cutoff: | ||
| logger.warning(f"Upper freq={fmax} > hwp freq cutoff={np.round(frequency_cutoff, 2)}. Limiting to hwp freq cutoff.") |
Contributor
There was a problem hiding this comment.
Why did you change from >= to >? Also if the np.round rounding is just for prettifying the logs you can use this notation with f-strings: f"{float:.Nf}" where N is the number of sig-figs you want to show (or you can use .Ng if you want display in scientific notation for large or small floats).
Contributor
Author
There was a problem hiding this comment.
I changed >= to > since If fmax == frequency_cutoff we don't need to change anything or throw a warning since it is already at the bound.
Updated to use f string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quick fix for a logging warning in preprocessing which is misleading. The line will print something like:
Upper freq=2 > hwp_freq=2.1035060065284457. Limiting to hwp_freqBut it is actually comparing the frequency to a frequency cutoff which is less than that value.