Merged
Conversation
msilvafe
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a preprocessing run is interrupted after copying the temp h5 file into the final h5 archive, but before the temp file is deleted, there will be a lingering temp file that will cause
save_group_and_cleanupto fail with:RuntimeError: Unable to synchronously copy object (destination object already exists)This checks for the above error and removes the file when it is encountered whether
overwriteisTrueor not (if overwriting, we want to remove the temp file so we can re-run it, and if overwrite isFalseit will cause a re-run since we decided that entries in the archive h5 file will be deleted if they are not in the sqlite db usingcleanup_archive).