Conversation
…ing_step1 and step2. Added functionality to run as parallel processing job on a cluster. Included some documentation in site_pipeline.rst
f4fe09a to
89ec639
Compare
Merging current master
99db759 to
03ed8e9
Compare
|
I will begin to make changes to this code to include true Az/El locations to correspond with each xi-eta detector hit. Before I do that I would like to close out this PR and start fresh. |
|
Nomenclature notes differing between Tomoki's initial PR and now:
|
mhasself
left a comment
There was a problem hiding this comment.
Thanks for pushing this through. I have some documentation and standardization requests. @msilvafe or @mmccrackan please do sign off on changes to flagman.py and processes.py.
I'm ok with the changes to flagman but I think the |
…ombineFlags, implemented MPI parallel processing, and other syntax updates.
…y wafer and final full wafer products
…ts through to the outputs of finalize focal plane. Useful for per-obs usecase, and when loaded with Receiver.load the values will be under det_boresight
|
My latest changes to |
skhrg
left a comment
There was a problem hiding this comment.
Only reviewing the focal plane changes for now. Looks good to me, just one minor question.
…etector pointing not included in inputs
This is a PR for the pointing workflow which I suggested last week.
There four new things.
sotodlib.coords.mapbased_pointing.pysotodlib.site_pipeline.make_mapbased_pointingsotodlib.site_pipeline.update_pointingsotodlib.site_pipeline.combine_focal_planesThe first one includes a function which make wafer centered single-detector maps and a function to reconstruct the rough pointing result from the map.
The second one is the site_pipeline, which use the
sotodlib.coords.mapbased_pointing.py. Note that the main function of it hastune_by_todargument, which call the third function,sotodlib.site_pipeline.update_pointing, and execute the tod based tuning with the map-based prior.The third one is the tod-based fitting, which I demonstrated before. It is super quick.
So once we get focal plane, we will only use this function by every single planet observation.
As it outputs a result file by each observation, it will be usefull for the pointing's elevation dependence study.
The forth one is a function to combine multiple focal_plane resultsets and make a
focal_plane_combined.hdfandfocal_plane_combined.hdf, which is the final product. Thefinarize_focal_planewill use this resultset and give a feedback to the third function.The figure below is the product for SATP3 run12, and I have checked the offset problem of map-domain is resolved by the tod-domain tuning.

I am a bit selfish and maybe it is breaking the initial design of site_pipeline. But I do think it is a realistic design for site_pipeline.