Fix MIME detection fallback when puremagic returns empty string#1353
Open
tgies wants to merge 1 commit intosimonw:mainfrom
Open
Fix MIME detection fallback when puremagic returns empty string#1353tgies wants to merge 1 commit intosimonw:mainfrom
tgies wants to merge 1 commit intosimonw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
puremagic.from_file()can return an empty string""instead of raisingPureError, which passed through as an invalid MIME type causing attachment validation errors.mimetypes.guess_type()as a fallback whenpuremagicreturns empty string or raises an exception."audio/x-wav": "audio/wav"toMIME_TYPE_FIXESsincemimetypesreturnsaudio/x-wavfor.wavfiles.MIME_TYPE_FIXESnormalization regardless of which detection method succeeded.Test plan
test_mimetype_from_path_fallback_on_empty_string— puremagic returns"", falls back to extensiontest_mimetype_from_path_fallback_on_puremagic_error— puremagic raises, falls back to extensiontest_mimetype_from_path_fallback_normalizes_wav— fallback result goes through MIME_TYPE_FIXEStest_mimetype_from_path_returns_none_if_no_detection— both methods fail →None