Open
Conversation
Author
|
Also replaced travis with GH actions. |
tycooon
force-pushed
the
add-method-coverage-support
branch
from
5cfa3a9 to
149d1db
Compare
pboling
approved these changes
Mar 29, 2023
pboling
left a comment
pboling
left a comment
There was a problem hiding this comment.
LGTM, though IMO dropping Ruby 2.4 and 2.5 will incur a major version bump. I think that's fine, just calling it out!
|
This looks fantastic changes to me and good additions for us as testers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See simplecov-ruby/simplecov#987.
Main page header view:
Main page table view:
Single file header view: