Skip to content

Add comments explaining widget init and event bubbling #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varadTheDeveloper wants to merge 1 commit into
base: stable
Choose a base branch
from
+3 −2
Open

Add comments explaining widget init and event bubbling #1773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xftp-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
"test:page": "playwright test test/page.spec.ts"
},
"devDependencies": {
"@playwright/test": "^1.50.0",
"@types/libsodium-wrappers-sumo": "^0.7.8",
"@types/node": "^20.0.0",
"@types/pako": "^2.0.3",
"@vitest/browser": "^3.0.0",
"@playwright/test": "^1.50.0",
"playwright": "^1.50.0",
"typescript": "^5.4.0",
"vite": "^6.0.0",
Expand Down
3 changes: 2 additions & 1 deletion xftp-web/web/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ async function main() {
})
}
await wasmReady
// Allow parent elements/document to listen for readiness event via event bubbling
app?.dispatchEvent(new CustomEvent('xftp:ready', {bubbles: true}))
}

Expand All @@ -42,7 +43,7 @@ function initApp() {
initUpload(app)
}
}

// Expose manual init hook for embedded/widget-based integrations
;(window as any).__xftp_initApp = async () => { await wasmReady; initApp() }

main().catch(err => {
Expand Down