Skip to content

[talents] Generic Apex Talent Detection #10740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renanthera merged 2 commits into from
Jan 10, 2026
Merged

[talents] Generic Apex Talent Detection #10740

renanthera merged 2 commits into from
Jan 10, 2026

Conversation

@renanthera
Copy link
Member

@renanthera renanthera commented Jan 5, 2026

No description provided.

@renanthera
Copy link
Member Author

renanthera commented Jan 10, 2026

image

:)

@renanthera
Copy link
Member Author

renanthera commented Jan 10, 2026

static children() could be a member function if each trait_data_t were to have a bool is_ptr member. I opted for a slightly messier set of parameters instead of adding a member to each, as it would be inconsistent with the typical data handling strategy.

@renanthera
[trait_data] Initial implementation of trait relatives for apex talen…
f507fd2 
…t detection and spell query filtration by relative count.

[talent] Implement generic Apex talent container and lookup.

[talent] Implement automatic resolution for assisted combat and expression.

[talent] Allow for PTR data to be selected as appropriate.
@renanthera
[dbc] Update data.
3675826
@renanthera renanthera force-pushed the 12.0/64914-generic-apex-handler branch from 738da28 to 3675826 Compare January 10, 2026 04:22
@renanthera renanthera merged commit 915fac4 into simulationcraft:midnight Jan 10, 2026
37 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@renanthera