Add Maximum Size for Metrics #916
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit metric size to be within 10MB Limit
Issue: #906
Python Version(s) Tested: 3.13
Operating System(s): Ubuntu 25.10
Documentation PR: Issue on Docs repo.
📝 Summary
Modifies the dispatcher classes to allow for additional "hold-back" thresholds to be defined.
🔄 Changes
simvue.factoryhas been removed and dispatchers moved tosimvue.dispatch.thresholdshas been added to the initialiser of allsimvue.dispatchclasses, this argument is a dictionary allowing you to specify additional thresholds, in this case{"max_size": 10 * 1024 * 1024}.add_itemnow includes ametadataargument where the value for checking against these thresholds is provided:add_item(item, object_type="metrics", ..., metadata=dict(max_size=len(item)).✔️ Checklist