adding back the ability to pass passwords to the database driver#433
Open
karcaw wants to merge 2 commits intosingularityhub:masterfrom
Open
adding back the ability to pass passwords to the database driver#433karcaw wants to merge 2 commits intosingularityhub:masterfrom
karcaw wants to merge 2 commits intosingularityhub:masterfrom
Conversation
Member
|
Looks good! Before we bump the version, do you want to do any tweaks to the other issues you pointed out (e.g., plugins?) |
Contributor
Author
|
yes, it would be good to wait, i'll get more PR's out tomorrow. |
Contributor
Author
|
ok, I put in the other PR's i was thinking of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like we lost the ability to pass a password to the database driver in #409