[codex] Treat Windows Hello key timeout as cancellation#144
Open
SirAndrosBot wants to merge 1 commit into
Open
[codex] Treat Windows Hello key timeout as cancellation#144SirAndrosBot wants to merge 1 commit into
SirAndrosBot wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When persistent key creation times out waiting for Windows Hello authorization, the plugin currently reports a generic system error and asks users to file a bug. The timeout should flow through the existing friendly cancellation path instead.
Closes #89.
Validation
Build was attempted with dotnet build src\KeePassWinHello.sln -c Release /p:DefineConstants=MONO, but this environment is missing .NET Framework 4.0 reference assemblies and the KeePass reference used by the project worktree.