Skip to content

[codex] Update key invalidation period options#146

Draft
SirAndrosBot wants to merge 1 commit into
masterfrom
codex/issue-40-scan-attempts
Draft

[codex] Update key invalidation period options#146
SirAndrosBot wants to merge 1 commit into
masterfrom
codex/issue-40-scan-attempts

Conversation

@SirAndrosBot

Copy link
Copy Markdown
Collaborator

What changed

  • Removed 10 Minutes from the saved-key invalidation dropdown.
  • Kept the existing 3 Days option available in the same dropdown.
  • Updated the dropdown index mapping after removing the 10-minute row.
  • Preserved compatibility with existing configurations that already contain the 10-minute value by showing them as the nearest remaining visible option, 15 Minutes.

Why

Issue #40 asks for safer saved-key invalidation behavior and discusses scan-attempt limits. The scan-attempt part is not implemented here because KeePassWinHello delegates the biometric prompt to Windows Hello/CNG. The plugin does not receive per-failed-scan events, so adding a setting named as a scan-attempt limit would not actually control fingerprint attempts. Reusing the existing provider retry count would be misleading because that value applies to whole retryable provider/system operations, not individual biometric scans inside the Windows Hello prompt.

This PR implements the low-risk, defensible part: removing the very short 10-minute retention option while preserving existing saved settings without breaking option loading.

Refs #40

Validation

  • Worker subagent implemented the change in an isolated branch.
  • Reviewer subagent checked the mapping and found no actionable issues.
  • git diff --check
  • MSBuild.exe src\KeePassWinHello.csproj /t:Rebuild /p:Configuration=Release /p:DefineConstants=MONO /p:FrameworkPathOverride=C:\Windows\Microsoft.NET\Framework\v4.0.30319 /p:ReferencePath=C:\proj\KeePassWinHello\lib

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants