[codex] Update key invalidation period options#146
Draft
SirAndrosBot wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
10 Minutesfrom the saved-key invalidation dropdown.3 Daysoption available in the same dropdown.15 Minutes.Why
Issue #40 asks for safer saved-key invalidation behavior and discusses scan-attempt limits. The scan-attempt part is not implemented here because KeePassWinHello delegates the biometric prompt to Windows Hello/CNG. The plugin does not receive per-failed-scan events, so adding a setting named as a scan-attempt limit would not actually control fingerprint attempts. Reusing the existing provider retry count would be misleading because that value applies to whole retryable provider/system operations, not individual biometric scans inside the Windows Hello prompt.
This PR implements the low-risk, defensible part: removing the very short 10-minute retention option while preserving existing saved settings without breaking option loading.
Refs #40
Validation
git diff --checkMSBuild.exe src\KeePassWinHello.csproj /t:Rebuild /p:Configuration=Release /p:DefineConstants=MONO /p:FrameworkPathOverride=C:\Windows\Microsoft.NET\Framework\v4.0.30319 /p:ReferencePath=C:\proj\KeePassWinHello\lib