Reduces memory allocation via pooling and fixes race condition#5
Open
MarkCiliaVincenti wants to merge 2 commits intositeserver:mainfrom
Open
Reduces memory allocation via pooling and fixes race condition#5MarkCiliaVincenti wants to merge 2 commits intositeserver:mainfrom
MarkCiliaVincenti wants to merge 2 commits intositeserver:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thread A locks on key ABC and is processing
Thread B obtains locks for key ABC and is waiting for thread A to finish
Thread A finishes and removes the lock from the dictionary, while thread B enters the lock
Thread C tries to lock on key ABC but the entry was deleted by thread A, therefore threads B and C process concurrently despite that they share the same key.
This PR fixes this issue and also uses pooled semaphoreslim objects to reduce allocations.