Skip to content

bug: data wasnt using deepswift #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincentborko wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −8
Open

bug: data wasnt using deepswift #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions Sources/SkipFirebaseFunctions/SkipFirebaseFunctions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,8 @@ public class HTTPSCallableResult: KotlinConverting<com.google.firebase.functions
}

public var data: Any {
// WORKAROUND: Access getData() result through a local variable first
// to avoid potential crashes in Skip's property access transpilation
let rawData: Any? = platformValue.getData()
return rawData ?? [String: Any]()
}

// Alternative method-based access that properly converts Kotlin types to Swift
public func getDataSafe() -> Any {
// Convert Kotlin/Java types (HashMap, ArrayList) to Swift types (Dictionary, Array)
// This prevents JNI crashes when Skip's bridge tries to call .kotlin() on raw Java types
guard let rawData = platformValue.getData() else {
return [String: Any]()
}
Expand Down
Loading