Skip to content

Add executables from ANDROID_HOME to the PATH#631

Merged
marcprux merged 1 commit intoskiptools:mainfrom
dfabulich:gradle-android-home-platform-tools-path
Feb 27, 2026
Merged

Add executables from ANDROID_HOME to the PATH#631
marcprux merged 1 commit intoskiptools:mainfrom
dfabulich:gradle-android-home-platform-tools-path

Conversation

@dfabulich
Copy link
Contributor

Fixes #630

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

I manually uninstalled android-platform-tools to repro #630. I passed the build log to Cursor, which found the issue and generated this code. I reviewed the lines and tested it locally, ensuring that it fixed my local build.


@cla-bot cla-bot bot added the cla-signed Automatically-added indication of a signed Contributor License Agreement label Feb 26, 2026
@marcprux
Copy link
Member

Thanks. I had assumed that skiptools/skipstone#184 addressed this, but it looks like I never removed the Homebrew adb command from my PATH, and so I didn't see the failure.

As some point we should probably put the adb command launch behind skip adb so tool path handling is unified, but ADBCommand.swift is currently experimental and untested.

@marcprux marcprux merged commit d9721e8 into skiptools:main Feb 27, 2026
1 of 3 checks passed
@marcprux marcprux added bug Something isn't working project Issues involving the structure of a Skip project, including Xcode, Gradle, Studio, fastlane and CI setup Installation and setup issues, including Homebrew/Java installation and skip checkup issues labels Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla-signed Automatically-added indication of a signed Contributor License Agreement project Issues involving the structure of a Skip project, including Xcode, Gradle, Studio, fastlane and CI setup Installation and setup issues, including Homebrew/Java installation and skip checkup issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip launch builds fail on fresh installation without android-platform-tools

2 participants