Warn when skip doctor/skip checkup can't find any attached devices#196
Open
dfabulich wants to merge 2 commits intoskiptools:mainfrom
Open
Warn when skip doctor/skip checkup can't find any attached devices#196dfabulich wants to merge 2 commits intoskiptools:mainfrom
skip doctor/skip checkup can't find any attached devices#196dfabulich wants to merge 2 commits intoskiptools:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186
skip doctorwarns if it can't find devicesIf
skip doctordoesn't detect any attached Android devices, it will log a warning, like this:Otherwise, it will log how many devices it detected:
skip initcan now install to an emulatorskip inithas a new argument,--launch-android, which will attempt to launch the app on an emulator. I don't expect regular users will want to use it much, but I needed it forskip checkupskip checkupwill attempt to launch if it detects devicesWhen
skip checkupruns thedoctorcommand, it will return a boolean, saying whether it detected any devices. If it did detect devices,skip checkupwill passlaunchAndroid: truetoinitSkipProject. This will install and launch the app on an attached device.If
doctordetected no devices,checkupwill passlaunchAndroid: false. The conclusion will be successful with 1 warning.Skip Pull Request Checklist:
swift testI mostly used Cursor to generate this code. I reviewed every line and tested it manually:
skip doctorwith/without a running emulatorskip checkupwith/without a running emulator