fix(macos): startup crash, window controls, and full playlist loading#5
Open
taylorhayis wants to merge 2 commits into
Open
fix(macos): startup crash, window controls, and full playlist loading#5taylorhayis wants to merge 2 commits into
taylorhayis wants to merge 2 commits into
Conversation
CoreAudio can SIGSEGV when enumerating output configs on macOS 15; use default_output_config in spotix-core and librespot rodio instead. Windows were borderless with no traffic-light buttons on macOS; enable the native title bar and add File > Close Window (Cmd+W). Co-authored-by: Cursor <cursoragent@cursor.com>
get_playlists() only fetched one Spotify API page, so users with large libraries saw at most 50 playlists in the sidebar. Walk pages until offset >= total and cache each page separately. Add scripts/rebundle-macos-dev.sh and `just bundle-dev` to rebuild Spotix-Dev.app after local changes on macOS. Co-authored-by: Cursor <cursoragent@cursor.com>
taylorhayis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpal::Device::supported_output_configs()in spotix-core and librespot rodio; usedefault_output_config()instead (playback already resamples).scripts/rebundle-macos-dev.shandjust bundle-devto rebuild a localSpotix-Dev.appafter source changes.Problem
On macOS 15.7 (Apple Silicon), launching from source crashed immediately after audio init with a segfault in CoreAudio inside
supported_output_configs(), called from both spotix-core cpal output and librespot rodio.All windows used
.show_titlebar(false), so macOS had no close/minimize/maximize buttons and no File → Close menu item.get_playlists()only fetched one Spotify API page (limit=50,offset=0), so users with large libraries never saw their full playlist list in the sidebar.Changes
spotix-core/src/audio/output/cpal.rs— macOS workaround for CoreAudio crashlibrespot-playback-patch/src/audio_backend/rodio.rs— same workaround for librespot audio backendspotix-gui/src/ui/mod.rs,menu.rs,playlist.rs— native title bar on macOSspotix-gui/src/webapi/client.rs— paginate playlist list API callsscripts/rebundle-macos-dev.sh,justfile— local macOS dev bundle helperTest plan
cargo build -p spotix-gui --bin spotixon macOSjust bundle-dev/bash scripts/rebundle-macos-dev.shinstalls updatedSpotix-Dev.app