Add gpuEnableRx/Tx, avoid setting internal regs in rdmaTest#273
Open
JJL772 wants to merge 3 commits into
Open
Conversation
JJL772
force-pushed
the
pr-do-not-set-internal-regs
branch
from
f3c2f57 to
07866a9
Compare
JJL772
changed the title
…than the driver We rely on MAX_GPU_BUFFERS to allocate static arrays in a number of places. The assumption is that the hardware register will never give us more than that number of buffers. It's unlikely that MAX_GPU_BUFFERS will be upped to >1024 in the future, but just in case, add a sanity check so we don't end up with memory corruption in the kernel, if that day comes.
since gpuAddNvidiaMemory implicitly sets the write/read enable bits, there are some concerns that the FPGA may initiate transactions before the GPU is ready. For the GpuAsyncCore V4+ path, we'll mandate the usage of gpuEnableRx and gpuEnableTx after gpuAddNvidiaMemory to avoid this potential issue. gpuAddNvidiaMemory will also clear the write/read enable bits. The old V3 and earlier path remains unchanged.
JJL772
force-pushed
the
pr-do-not-set-internal-regs
branch
from
07866a9 to
aa08814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description