add tzdata to development dependencies#172
Open
5j9 wants to merge 1 commit intoslashmili:mainfrom
Open
Conversation
tzdata is used in tests and without it tests fail on windows. Windows users can now run `uv run pytest` and uv will handle dependencies correctly and all tests pass.
Owner
|
Thanks for adjustment! As I don't have windows, unfortunately I can't test it. I tried to run test on windows #173 but it failed because of some unknown timezon. |
Contributor
Author
That's the error I was referring to. In the test output, click on line 35 where it says One way to fix this might be:
I've not tested this myself, and while the exact setup may vary, the general approach should work. Also, I can close this pull request, and we can roll everything into a single one if that works better for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tzdata is used in tests and without it tests fail on windows. Windows users can now run
uv run pytestand uv will handle dependencies correctly and all tests pass.