Skip to content

add tzdata to development dependencies#172

Open
5j9 wants to merge 1 commit intoslashmili:mainfrom
5j9:tzdata
Open

add tzdata to development dependencies#172
5j9 wants to merge 1 commit intoslashmili:mainfrom
5j9:tzdata

Conversation

@5j9
Copy link
Copy Markdown
Contributor

@5j9 5j9 commented Oct 14, 2025

tzdata is used in tests and without it tests fail on windows. Windows users can now run uv run pytest and uv will handle dependencies correctly and all tests pass.

tzdata is used in tests and without it tests fail on windows.
Windows users can now run `uv run pytest` and uv will handle
dependencies correctly and all tests pass.
@slashmili
Copy link
Copy Markdown
Owner

Thanks for adjustment!

As I don't have windows, unfortunately I can't test it. I tried to run test on windows #173 but it failed because of some unknown timezon.

@5j9
Copy link
Copy Markdown
Contributor Author

5j9 commented Oct 15, 2025

As I don't have windows, unfortunately I can't test it. I tried to run test on windows #173 but it failed because of some unknown timezon.

That's the error I was referring to. In the test output, click on line 35 where it says tox: py313 to expand the results. Then scroll down until you see: ModuleNotFoundError: No module named 'tzdata'

One way to fix this might be:

  1. merge this pull request.
  2. in the other pull request which should be on top of this one, In test.yaml, replace python -m pip install --upgrade pip with python -m pip install --upgrade uv
  3. in tox.ini, replace python -m unittest discover tests -v with uv run pytest

I've not tested this myself, and while the exact setup may vary, the general approach should work.

Also, I can close this pull request, and we can roll everything into a single one if that works better for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants