fix: create session sync client before metadata extraction#156
Open
vinhnxv wants to merge 1 commit intoslopus:mainfrom
Open
fix: create session sync client before metadata extraction#156vinhnxv wants to merge 1 commit intoslopus:mainfrom
vinhnxv wants to merge 1 commit intoslopus:mainfrom
Conversation
Prevents race condition where multiple session client instances could be created inside the extractSDKMetadataAsync callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractSDKMetadataAsynccallbackProblem
The session sync client was being created inside the
extractSDKMetadataAsynccallback:This could lead to race conditions with multiple session client instances.
Solution
Create the session client once, before the async metadata extraction:
Test Plan