FIX: Unable to build dedicated server on VS 2022#1367
Open
Redlonghead wants to merge 1 commit intosmartcmd:mainfrom
Open
FIX: Unable to build dedicated server on VS 2022#1367Redlonghead wants to merge 1 commit intosmartcmd:mainfrom
Redlonghead wants to merge 1 commit intosmartcmd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows users to build the dedicated server with cmake version 3.24-3.31. VS 2022 is using cmake version 3.31.
Changes
Previous Behavior
When building the dedicated server with cmake versions 3.24-3.31 it would fail with the following error:
Root Cause
In file
cmake/CopyFileScript.cmakeon line 22 the IF statement uses a new operator "IN_LIST" with out specifying the minimum version for cmake. The latest versions of cmake (4.0+) removed this policy to default to NEW while version 3.31 used in VS would still default to OLD.New Behavior
You can build the dedicated server on cmake version 3.24-3.31.
Fix Implementation
Added
cmake_minimum_required(VERSION 3.24)to filecmake/CopyFileScript.cmake.AI Use Disclosure
No AI was used.
Related Issues