Adding discord rich presence support for Windows64 (Early)

[acth2]

Description

Reintroducing the Discord rich presence system, this idea come from #954

Changes

Previous Behavior

There were the functions for rich presence but no code inside of them: the code is still in an very early state but it works!

Root Cause

I needed to recode the discord rich presence but the system that tracks the players action and that permit me to modify what the rich presence says was already coded!

New Behavior

in Minecraft:Init i call ProfileManager.RichPresenceInit(...) and in Minecraft::tick i call player->updateRichPresence(); to constantly update the rich presence
NEW: I now use the Minecraft.Client/Windows64Media/loc/stringsRichPresence.xml file that contains the rich presence text (thanks to eff3ry for pointing that)

Fix Implementation

Previously it looked like this:
void C_4JProfile::RichPresenceInit(int iPresenceCount, int iContextCount) {}
void C_4JProfile::SetRichPresenceContextValue(int iPad, int iContextID, int iVal) {}
i just called discord-rpc.h and followed instructions to make a rich presence from there:

It works but its ugly for now!

AI Use Disclosure

nop

Related Issues

• Related to [Suggestion] Discord rich presence #954

[eff3ry]

would it be better to hook directly into the localised strings?
Minecraft.Client/Windows64Media/loc/stringsRichPresence.xml

[eff3ry]

Obviously this wont be a drop in replacement but just an example, app is referenced in many files the same way, not sure which file app is defined though 🤷‍♂️

static std::string s_detailsUtf8;
static std::string s_stateUtf8;

s_detailsUtf8 = app.GetString(IDS_DISCORD_DETAILS_PLAYING_LCE);
discordPresence.details = s_detailsUtf8.c_str();

switch (iVal) {
  case CONTEXT_GAME_STATE_NETHER:
    s_stateUtf8 = app.GetString(IDS_DISCORD_STATE_NETHER);
    break;
  ...
  default:
    s_stateUtf8 = app.GetString(IDS_DISCORD_STATE_SURVIVING);
    break;
}
discordPresence.state = s_stateUtf8.c_str();
Discord_UpdatePresence(&discordPresence);

[acth2]

would it be better to hook directly into the localised strings? Minecraft.Client/Windows64Media/loc/stringsRichPresence.xml

thx i'll do it now

[acth2]

Obviously this wont be a drop in replacement but just an example, app is referenced in many files the same way, not sure which file app is defined though 🤷‍♂️

static std::string s_detailsUtf8;
static std::string s_stateUtf8;

s_detailsUtf8 = app.GetString(IDS_DISCORD_DETAILS_PLAYING_LCE);
discordPresence.details = s_detailsUtf8.c_str();

switch (iVal) {
  case CONTEXT_GAME_STATE_NETHER:
    s_stateUtf8 = app.GetString(IDS_DISCORD_STATE_NETHER);
    break;
  ...
  default:
    s_stateUtf8 = app.GetString(IDS_DISCORD_STATE_SURVIVING);
    break;
}
discordPresence.state = s_stateUtf8.c_str();
Discord_UpdatePresence(&discordPresence);

It's done thx for the example btw!

[nitrate92]

would it be better to hook directly into the localised strings? Minecraft.Client/Windows64Media/loc/stringsRichPresence.xml

I am a little late to the party but this is more like what I proposed initially since I noticed the strings in the code while digging around.

[SimplyCEO]

Could this code be placed under a definition, please?
I do not have Discord, so, how I see, this is extra unused binary.

[acth2]

Could this code be placed under a definition, please? I do not have Discord, so, how I see, this is extra unused binary.

yep i w as thinking about doing that