Conversation
tt-cll
requested review from
agusaldasoro,
b-gopalswami,
carte7000,
makramkd,
matYang,
ogtownsend and
winder
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for granting burn/mint rights when deploying burn/mint token pools for additional burn/mint token reference types (including ERC677-based burn/mint tokens), and expands regression tests to cover these cases.
Changes:
- Introduces a new
BurnMintTokencontract type constant and extends burn/mint token type detection. - Updates the v2.0.0 token adapter to grant mint/burn roles even when the pool already exists, and selects the correct grant operation for ERC677 tokens.
- Adds a new v1.0.0 operation for
BurnMintERC677.grantMintAndBurnRolesand extends v1.0.0 pool adapter role-grant switching. - Expands adapter tests to cover multiple token ref types/qualifiers and ERC677 tokens.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/utils/common.go | Adds BurnMintToken contract type used for burn/mint token classification. |
| chains/evm/deployment/v2_0_0/adapters/tokens.go | Grants roles for already-deployed pools and routes role granting to ERC677-specific operation when applicable. |
| chains/evm/deployment/v2_0_0/adapters/tokens_test.go | Expands regression coverage to include multiple burn/mint token ref types and ERC677 deployment. |
| chains/evm/deployment/v1_0_0/operations/burn_mint_erc677/burn_mint_erc677.go | Adds ERC677 role-grant write operation wrapper. |
| chains/evm/deployment/v1_0_0/adapters/pool_adapter.go | Adds ERC677 token type cases to role-grant dispatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -37,6 +37,7 @@ const ( | |||
| // Pools | |||
| TokenPoolFactory cldf.ContractType = "TokenPoolFactory" | |||
| LinkToken cldf.ContractType = "LinkToken" | |||
| require.NoError(t, ds.Addresses().Add(datastore.AddressRef{ | ||
| ChainSelector: tc.chainSel, | ||
| Address: tokenAddr.Hex(), | ||
| Type: tc.tokenRefType, |
| } | ||
| return owner == caller, nil | ||
| }, | ||
| Validate: func(address common.Address) error { return nil }, |
Comment on lines
+175
to
+182
| batchOp, err := grantMintBurnRoles(matches[0]) | ||
| if err != nil { | ||
| return sequences.OnChainOutput{}, err | ||
| } | ||
| if batchOp == nil { | ||
| return sequences.OnChainOutput{}, nil | ||
| } | ||
| return sequences.OnChainOutput{BatchOps: []mcms_types.BatchOperation{*batchOp}}, nil |
Comment on lines
+125
to
+131
| toknRef, lookupErr := datastore_utils.FindAndFormatRef(input.ExistingDataStore, datastore.AddressRef{ | ||
| ChainSelector: input.ChainSelector, | ||
| Address: tokenAddr, | ||
| }, input.ChainSelector, datastore_utils.FullRef) | ||
| if lookupErr != nil || !isBurnMintTokenType(toknRef.Type) { | ||
| return nil, nil | ||
| } |
|
chris-de-leon-cll
approved these changes
May 4, 2026
ma33r
approved these changes
May 4, 2026
|
|
||
| var ContractType cldf_deployment.ContractType = cciputils.BurnMintToken | ||
|
|
||
| const burnMintERC677ABI = `[{"inputs":[],"name":"BURN_MINT_ADMIN_ROLE","outputs":[{"internalType":"bytes32","name":"","type":"bytes32"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"DEFAULT_ADMIN_ROLE","outputs":[{"internalType":"bytes32","name":"","type":"bytes32"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"bytes32","name":"role","type":"bytes32"}],"name":"getRoleAdmin","outputs":[{"internalType":"bytes32","name":"","type":"bytes32"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"bytes32","name":"role","type":"bytes32"},{"internalType":"address","name":"account","type":"address"}],"name":"grantRole","outputs":[],"stateMutability":"nonpayable","type":"function"},{"inputs":[{"internalType":"bytes32","name":"role","type":"bytes32"},{"internalType":"address","name":"account","type":"address"}],"name":"hasRole","outputs":[{"internalType":"bool","name":"","type":"bool"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"owner","outputs":[{"internalType":"address","name":"","type":"address"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"address","name":"burnAndMinter","type":"address"}],"name":"grantMintAndBurnRoles","outputs":[],"stateMutability":"nonpayable","type":"function"}]` |
Collaborator
There was a problem hiding this comment.
@tt-cll quick heads up - looks like chainlink-evm already has this ABI supported:
Also, I noticed a few discrepancies with this ABI and the BurnMintERC677 source code - for example DEFAULT_ADMIN_ROLE, getRoleAdmin, etc. are not present in the BurnMintERC677 contract if I'm not mistaken 👀
Let me know if this is legit and I can help fix this in the PR I have here: #2015
Collaborator
Author
There was a problem hiding this comment.
yeah that is a bug. Let's fix it as part of the other PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.