Conversation
|
👋 tt-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes legacy token-pool configuration import during 2.0.0 EVM upgrade flows by carrying the source pool version through import and rebasing imported inbound rate limits when they came from pre-1.6.1 pools.
Changes:
- Tracks the imported legacy pool version alongside imported rate-limit and remote-pool config.
- Rebases imported inbound rate limits from remote/source decimals to local/destination decimals for legacy (<1.6.1) EVM pools before applying them to 2.0.0 pools.
- Adds unit tests for the new inbound rate-limit normalization helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
chains/evm/deployment/v2_0_0/sequences/tokens/configure_token_pool_for_remote_chain.go |
Adds legacy-version-aware import handling and decimal rebasing for imported inbound rate limits. |
chains/evm/deployment/v2_0_0/sequences/tokens/configure_token_pool_for_remote_chain_internal_test.go |
Adds helper-level tests for inbound rate-limit normalization behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tt-cll
requested review from
agusaldasoro,
asoliman92,
b-gopalswami,
carte7000,
chris-de-leon-cll,
ogtownsend and
winder
chris-de-leon-cll
approved these changes
May 4, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.