Skip to content

DON Time State Logging #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DylanTinianov wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −2
Open

DON Time State Logging #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8e816
Add state logging
DylanTinianov Mar 26, 2026
b62cd8d
Merge branch 'main' into CRE-2497-dontime-logging
DylanTinianov Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/workflows/dontime/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ func (p *Plugin) Observation(_ context.Context, outctx ocr3types.OutcomeContext,
requests[req.WorkflowExecutionID] = int64(req.SeqNum)
}

p.lggr.Infow("Observation built",
"requestsIncluded", len(requests),
"pendingRequestsInStore", len(p.store.GetRequests()),
)

observation := &pb.Observation{
Timestamp: time.Now().UTC().UnixMilli(),
Requests: requests,
Expand Down Expand Up @@ -214,6 +219,7 @@ func (p *Plugin) Outcome(_ context.Context, outctx ocr3types.OutcomeContext, _ t
p.lggr.Infow("Outcome computed",
"observedDonTimesEntries", len(outcome.ObservedDonTimes),
"outcomeSizeBytes", len(outcomeBytes),
"pendingRequestsInStore", len(p.store.GetRequests()),
)
return outcomeBytes, err
}
Expand Down
10 changes: 8 additions & 2 deletions pkg/workflows/dontime/transmitter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ func (t *Transmitter) Transmit(_ context.Context, _ types.ConfigDigest, _ uint64
t.store.replaceDonTimes(currentDonTimes)
t.store.setLastObservedDonTime(outcome.Timestamp)

t.lggr.Infow("Transmitting timestamps", "lastObservedDonTime", outcome.Timestamp)

responsesDelivered := 0
Copy link
Copy Markdown
Contributor

@justinkaseman justinkaseman Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better as a Prometheus counter (dontime_responses_delivered_total) incremented per transmit round? That way we could put it in a dashboard.

Worth considering whether pendingRequestsInStore should also be a gauge.

for executionID, donTimes := range outcome.ObservedDonTimes {
request := t.store.GetRequest(executionID)
if request == nil {
Expand All @@ -59,9 +58,16 @@ func (t *Transmitter) Transmit(_ context.Context, _ types.ConfigDigest, _ uint64
Timestamp: donTime,
Err: nil,
})
responsesDelivered++
}
}

t.lggr.Infow("Transmitting timestamps",
"lastObservedDonTime", outcome.Timestamp,
"observedDonTimesEntries", len(outcome.ObservedDonTimes),
"responsesDelivered", responsesDelivered,
)

return nil
}

Expand Down
Loading